Added server mqtt over websockets #997
clippy
5 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 5 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.85.0-nightly (14ee63a3c 2024-12-29)
- cargo 1.85.0-nightly (c86f4b3a1 2024-12-24)
- clippy 0.1.85 (14ee63a3c6 2024-12-29)
Annotations
Check failure on line 208 in src/v5/client/connector.rs
github-actions / clippy
useless conversion to the same type: `error::ClientError<std::boxed::Box<v5::codec::packet::connack::ConnectAck>>`
error: useless conversion to the same type: `error::ClientError<std::boxed::Box<v5::codec::packet::connack::ConnectAck>>`
--> src/v5/client/connector.rs:208:27
|
208 | Ok(res) => res.map_err(From::from),
| ^^^^^^^^^^^^^^^^^^^^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check failure on line 204 in src/v3/client/connector.rs
github-actions / clippy
useless conversion to the same type: `error::ClientError<v3::codec::packet::ConnectAck>`
error: useless conversion to the same type: `error::ClientError<v3::codec::packet::ConnectAck>`
--> src/v3/client/connector.rs:204:27
|
204 | Ok(res) => res.map_err(From::from),
| ^^^^^^^^^^^^^^^^^^^^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[deny(clippy::useless_conversion)]` implied by `#[deny(warnings)]`
Check failure on line 246 in src/v5/codec/packet/subscribe.rs
github-actions / clippy
operator precedence can trip the unwary
error: operator precedence can trip the unwary
--> src/v5/codec/packet/subscribe.rs:245:13
|
245 | / u8::from(self.qos)
246 | | | (self.no_local as u8) << 2
| |____________________________________________^ help: consider parenthesizing your expression: `u8::from(self.qos) | ((self.no_local as u8) << 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
Check failure on line 247 in src/v5/codec/packet/subscribe.rs
github-actions / clippy
operator precedence can trip the unwary
error: operator precedence can trip the unwary
--> src/v5/codec/packet/subscribe.rs:245:13
|
245 | / u8::from(self.qos)
246 | | | (self.no_local as u8) << 2
247 | | | (self.retain_as_published as u8) << 3
| |_______________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
245 ~ u8::from(self.qos)
246 + | (self.no_local as u8) << 2 | ((self.retain_as_published as u8) << 3)
|
Check failure on line 248 in src/v5/codec/packet/subscribe.rs
github-actions / clippy
operator precedence can trip the unwary
error: operator precedence can trip the unwary
--> src/v5/codec/packet/subscribe.rs:245:13
|
245 | / u8::from(self.qos)
246 | | | (self.no_local as u8) << 2
247 | | | (self.retain_as_published as u8) << 3
248 | | | u8::from(self.retain_handling) << 4,
| |_____________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
note: the lint level is defined here
--> src/lib.rs:1:27
|
1 | #![deny(rust_2018_idioms, warnings, unreachable_pub)]
| ^^^^^^^^
= note: `#[deny(clippy::precedence)]` implied by `#[deny(warnings)]`
help: consider parenthesizing your expression
|
245 ~ u8::from(self.qos)
246 + | (self.no_local as u8) << 2
247 ~ | (self.retain_as_published as u8) << 3 | (u8::from(self.retain_handling) << 4),
|