feat: add extract_readable_strings function with advanced filtering support and reorganize string extraction code #2720
Conversation
…upport and reorganize string extraction code - Introduces a new function `extract_readable_strings` to retrieve multiple human-readable substrings from a payload, with an optional filter callback for advanced matching (e.g., FQDN detection). - Moves the old string extraction function (`ndpi_has_human_readable_string`) from nfdpi_utils.c to readable_string.c, consolidating all string extraction logic into one location. This commit complements or replaces the existing `ndpi_has_human_readable_string` by providing: 1) Multi-substring extraction. 2) More flexible handling of textual data. 3) An optional user-defined filter for fine-tuned processing. References ntop#2708
|
| char **items; ///< Array of strings | ||
| size_t count; ///< Number of strings currently stored | ||
| size_t capacity; ///< Allocated capacity of the list | ||
| } string_list_t; |
There was a problem hiding this comment.
Please use ndpi_ as prefix for all public functions and structures.
Here ndpi_string_list_t
| size_t capacity; ///< Allocated capacity of the list | ||
| } string_list_t; | ||
|
|
||
| void string_list_free(string_list_t *list); |
|
|
||
| void string_list_free(string_list_t *list); | ||
|
|
||
| string_list_t* extract_readable_strings(const unsigned char *buffer, size_t buffer_len, |
| @@ -0,0 +1,305 @@ | |||
| /* | |||
| * ndpi_utils.c | |||
There was a problem hiding this comment.
Please rename this file in ndpi_readable_string.c and update this comment
| /* | ||
| * ndpi_utils.c | ||
| * | ||
| * Copyright (C) 2011-24 - ntop.org and contributors |
There was a problem hiding this comment.
Copyright (C) 2025 - ntop.org and contributors
| * @return A pointer to the newly allocated string_list_t structure, or NULL on failure. | ||
| */ | ||
| static string_list_t *string_list_create(size_t initial_capacity) { | ||
| string_list_t *list = calloc(1, sizeof(string_list_t)); |
There was a problem hiding this comment.
Please use the internal wrapper for memory allocations, free and strdup
Yes, it is possible. I will do it soon and, while at it, I will also remove the deprecated functions. |
Please sign (check) the below before submitting the Pull Request:
Link to the related issue:
References #2708
Describe changes:
extract_readable_stringsto retrieve multiple human-readable substrings from a payload, with an optional filter callback for advanced matching (e.g., FQDN detection).ndpi_has_human_readable_string) from nfdpi_utils.c to readable_string.c, consolidating all string extraction logic into one location.This commit complements or replaces the existing
ndpi_has_human_readable_stringby providing: