IF-8978 delete visibility default value of Image (#111)

* IF-8978 delete visibility default value of Image
nttcom · Jan 18, 2024 · e859a0c · e859a0c
1 parent f0b8873
commit e859a0c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/ecl/data_source_ecl_imagestorages_image_v2_test.go b/ecl/data_source_ecl_imagestorages_image_v2_test.go
@@ -118,6 +118,7 @@ resource "ecl_imagestorages_image_v2" "image_1" {
     foo = "bar"
     bar = "foo"
   }
+  visibility = "private"
 }
 
 `, localFileForDataSourceTest)

diff --git a/ecl/resource_ecl_imagestorages_image_v2.go b/ecl/resource_ecl_imagestorages_image_v2.go
@@ -113,7 +113,7 @@ func resourceImageStoragesImageV2() *schema.Resource {
 				Type:         schema.TypeString,
 				Optional:     true,
 				ValidateFunc: resourceImageStoragesImageV2ValidateVisibility,
-				Default:      "private",
+				Computed:     true,
 			},
 
 			"properties": &schema.Schema{
@@ -186,7 +186,6 @@ func resourceImageStoragesImageV2Create(d *schema.ResourceData, meta interface{}
 		MinDisk:         d.Get("min_disk_gb").(int),
 		MinRAM:          d.Get("min_ram_mb").(int),
 		Protected:       &protected,
-		Visibility:      &visibility,
 		Properties:      imageProperties,
 	}
 
@@ -195,6 +194,10 @@ func resourceImageStoragesImageV2Create(d *schema.ResourceData, meta interface{}
 		createOpts.Tags = resourceImageStoragesImageV2BuildTags(tags)
 	}
 
+	if visibility != "" {
+		createOpts.Visibility = &visibility
+	}
+
 	d.Partial(true)
 
 	log.Printf("[DEBUG] Create Options: %#v", createOpts)

diff --git a/website/docs/r/imagestorages_image_v2.html.markdown b/website/docs/r/imagestorages_image_v2.html.markdown
@@ -52,7 +52,7 @@ The following arguments are supported:
 
 * `verify_checksum` - (Optional) If false, the checksum will not be verified once the image is finished uploading. Defaults to true.
 
-* `visibility` - (Optional) Scope of image accessibility. Must be one of "public", "private". Defaults to "private".
+* `visibility` - (Optional) Scope of image accessibility. Must be one of "public", "private", "shared".
 
 * `peroperties` - (Optional) A map of key/value pairs to set freeform information about an image.