fix: add get season question endpoint

ntuscds · Feb 24, 2024 · a426e95 · a426e95
1 parent c74203b
commit a426e95
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/apps/challenges/src/controllers/season.ts b/apps/challenges/src/controllers/season.ts
@@ -33,6 +33,7 @@ const getSeasons = asyncHandler(async (req: Request, res: Response) => {
 
     try {
         const seasons = await SeasonService.getSeasonsByDate(_startDate, _endDate);
+
         res.status(200).json({
             seasons: seasons,
         });
@@ -165,9 +166,15 @@ const getSeasonRankings = asyncHandler(async (req: Request, res: Response) => {
 const getSeasonQuestions = asyncHandler(async (req: Request, res: Response) => {
     try {
         const seasonID = zodIsValidObjectId.parse(req.params.seasonID);
+
+        const season = await SeasonService.getSeasonByID(seasonID);
+        if (!season) {
+            res.status(404).json({ message: 'Season not found' });
+            return;
+        }
 
         const questions = await SeasonService.getSeasonQuestions(seasonID);
-
+        
         res.status(200).json(questions);
     } catch (err) {
         if (err instanceof z.ZodError) {

diff --git a/apps/challenges/src/model/season.ts b/apps/challenges/src/model/season.ts
@@ -1,4 +1,13 @@
 import mongoose, { Schema } from 'mongoose';
+import { QuestionModel } from './question';
+
+export interface GetSeasonResp {
+    id: mongoose.Types.ObjectId;
+    title: string;
+    startDate: Date;
+    endDate: Date;
+    questions: QuestionModel[];
+}
 
 export interface SeasonModel {
     _id: mongoose.Types.ObjectId;