Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/merch products #139

Merged
merged 11 commits into from
Jan 29, 2024
Merged

Fix/merch products #139

merged 11 commits into from
Jan 29, 2024

Conversation

Iyzyman
Copy link
Contributor

@Iyzyman Iyzyman commented Jan 24, 2024

  • Fixing products page as per requested in merch-products/ivan pr

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
website-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 1:42pm

@Iyzyman Iyzyman requested a review from limivann January 24, 2024 14:39
@github-actions github-actions bot temporarily deployed to Preview - website January 24, 2024 14:44 Inactive
@Iyzyman Iyzyman requested a review from chanbakjsd January 24, 2024 14:45
limivann
limivann previously approved these changes Jan 26, 2024
Copy link
Contributor

@limivann limivann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM!

apps/cms/src/@types/Product.ts Outdated Show resolved Hide resolved
Copy link
Member

@chanbakjsd chanbakjsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the issues. LGTM!

@github-actions github-actions bot temporarily deployed to Preview - website January 29, 2024 13:44 Inactive
Copy link

Deployment preview link: https://website-6j5zq6brg-cse-it.vercel.app

@Iyzyman Iyzyman merged commit 5d322e0 into main Jan 29, 2024
6 checks passed
limivann added a commit that referenced this pull request Jan 31, 2024
* Added merch products page

* fix linting issues

* Added merch products page

* fix linting issues

* Add delete and edit buttons for product page

* Using type definition from merch.ts

* Fix linting errors

* Fix linting errors

* import Product from types

---------

Co-authored-by: LimIvan336 <[email protected]>
Co-authored-by: Chung Zhi Xuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants