Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add merch promotions page #149

Merged
merged 25 commits into from
Aug 28, 2024
Merged

Add merch promotions page #149

merged 25 commits into from
Aug 28, 2024

Conversation

spaceman03
Copy link
Contributor

@spaceman03 spaceman03 requested a review from Iyzyman March 8, 2024 10:28
@spaceman03 spaceman03 requested a review from jack-thant as a code owner March 8, 2024 10:28
@vercel Vercel
Copy link

vercel bot commented Mar 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
website-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 5:09am

@github-actions github-actions bot temporarily deployed to Preview - website March 8, 2024 10:32 Inactive
@spaceman03 spaceman03 requested a review from chanbakjsd as a code owner March 17, 2024 14:57
@github-actions github-actions bot temporarily deployed to Preview - website June 24, 2024 15:18 Inactive
@github-actions github-actions bot temporarily deployed to Preview - website August 21, 2024 12:38 Inactive
@limivann
Copy link
Contributor

@spaceman03 Lint issue can be found here:
https://quora.com/Why-is-component-definition-missing-display-name-react-display-name-error-occur-JavaScript-HTML-arrays-reactjs-antd-development

CC: @Iyzyman

@spaceman03
Copy link
Contributor Author

Thank you for your help!! @limivann

@Iyzyman Iyzyman self-requested a review August 23, 2024 09:00
Iyzyman
Iyzyman reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@Iyzyman Iyzyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hi Zhixuan, great work so far, but could you shift the create new promotion button to the right corner instead?

Also could you help make the list width take up 100% of the space, refer to the lists in orders and products for reference.

Thanks!

@github-actions github-actions bot temporarily deployed to Preview - website August 23, 2024 14:54 Inactive
@github-actions github-actions bot temporarily deployed to Preview - website August 26, 2024 05:13 Inactive
@github-actions GitHub Actions
Copy link

Deployment preview link: https://website-jaqvhyvlp-cse-it.vercel.app

@chanbakjsd chanbakjsd enabled auto-merge (squash) August 26, 2024 14:46
jack-thant
jack-thant approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@jack-thant jack-thant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@chanbakjsd chanbakjsd merged commit b9b6393 into main Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iyzyman Iyzyman Iyzyman approved these changes

@jack-thant jack-thant jack-thant approved these changes

@chanbakjsd chanbakjsd chanbakjsd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spaceman03 @limivann @chanbakjsd @jack-thant @Iyzyman