Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(cms): Revert Order API Sync #153

Merged
merged 3 commits into from
May 7, 2024
Merged

revert(cms): Revert Order API Sync #153

merged 3 commits into from
May 7, 2024

Conversation

mrzzy
Copy link
Contributor

@mrzzy mrzzy commented Apr 7, 2024

Motivation

Order API Sync #142 created a circular dependency:

flowchart
  direction TB
  payload[Payload CMS] -->|generates CMS types to| types[package/types]
  types -->|Sync merch types to| payload
Loading

Contents

Reverts #142 to break circular dependency.

  • Manually align Order API with Order types in package/types/merch.ts

@vercel Vercel
Copy link

vercel bot commented Apr 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
website-ui-storybook ✅ Ready (Inspect) Visit Preview May 7, 2024 2:07am

@mrzzy mrzzy requested review from Iyzyman and chanbakjsd April 7, 2024 06:32
@mrzzy mrzzy marked this pull request as ready for review April 7, 2024 06:33
@mrzzy mrzzy requested a review from jack-thant as a code owner April 7, 2024 06:33
@mrzzy mrzzy self-assigned this Apr 7, 2024
@mrzzy mrzzy added bug Something isn't working cms labels Apr 7, 2024
@github-actions github-actions bot temporarily deployed to Preview - website April 7, 2024 22:08 Inactive
jack-thant
jack-thant approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@jack-thant jack-thant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrzzy mrzzy force-pushed the revert/order-api-sync branch from 895b12d to 0722efd Compare May 7, 2024 02:05
@github-actions github-actions bot temporarily deployed to Preview - website May 7, 2024 02:09 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Deployment preview link: https://website-pznz7uyfw-cse-it.vercel.app

chanbakjsd
chanbakjsd approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@chanbakjsd chanbakjsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chanbakjsd chanbakjsd merged commit 10080ff into main May 7, 2024
6 checks passed
@chanbakjsd chanbakjsd deleted the revert/order-api-sync branch May 7, 2024 02:54
@limivann limivann mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-thant jack-thant jack-thant approved these changes

@chanbakjsd chanbakjsd chanbakjsd approved these changes

@Iyzyman Iyzyman Awaiting requested review from Iyzyman

Assignees

@mrzzy mrzzy

Labels
bug Something isn't working cms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrzzy @chanbakjsd @jack-thant