Code cleanup

nuages-io · Feb 14, 2022 · 53d6e28 · 53d6e28
1 parent cdd47eb
commit 53d6e28
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 16 deletions.
diff --git a/Nuages.TaskRunner.Samples.Console/Program.cs b/Nuages.TaskRunner.Samples.Console/Program.cs
@@ -33,7 +33,7 @@ private static async Task MainAsync(string[] args)
             var data = new OutputToConsoleTaskData( "Method 1 : Your name is : " + message);
             await taskRunner.ExecuteAsync<OutputToConsoleTask, OutputToConsoleTaskData>(data);
 
-            //Execute the task : Method 2 (Data Typed)
+            //Execute the task : Method 2 (Untyped)
             var taskDef =  RunnableTaskDefinitionCreator<OutputToConsoleTask>.Create(new { Message = "Method 2 : Your name is : " + message });
             await taskRunner.ExecuteAsync(taskDef);
 

diff --git a/Nuages.TaskRunner/ITaskRunnerService.cs b/Nuages.TaskRunner/ITaskRunnerService.cs
@@ -3,7 +3,5 @@ namespace Nuages.TaskRunner;
 public interface ITaskRunnerService
 {
     Task<IRunnableTask> ExecuteAsync(RunnableTaskDefinition taskDef);
-    //Task<T> ExecuteAsync<T>(RunnableTaskDefinition taskDef) where T : IRunnableTask;
-    //Task<T> ExecuteAsync<T>(object data, string? userId = null) where T : IRunnableTask;
     Task<T> ExecuteAsync<T,TD>(TD data, string? userId = null) where T : IRunnableTask;
 }
diff --git a/Nuages.TaskRunner/TaskRunnerService.cs b/Nuages.TaskRunner/TaskRunnerService.cs
@@ -18,25 +18,13 @@ public TaskRunnerService( IServiceProvider serviceProvider, ILogger<TaskRunnerSe
         _serviceProvider = serviceProvider;
         _authorizers = authorizers;
     }
-
-    // public async Task<T> ExecuteAsync<T>(RunnableTaskDefinition taskDef) where T : IRunnableTask
-    // {
-    //     return (T) await ExecuteAsync(taskDef);
-    // }
-    //
+
     public async Task<T> ExecuteAsync<T,TD>(TD data, string? userId = null) where T : IRunnableTask
     {
         var taskDef = RunnableTaskDefinitionCreator<T>.Create(data, userId);
 
         return (T) await ExecuteAsync(taskDef);
     }
-
-    // public async Task<T> ExecuteAsync<T>(object data, string? userId = null) where T : IRunnableTask
-    // {
-    //     var taskDef = RunnableTaskDefinitionCreator<T>.Create(data, userId);
-    //     
-    //     return (T) await ExecuteAsync(taskDef);
-    // }
 
     protected virtual async Task<bool> IsAuthorizedToRunAsync(RunnableTaskDefinition taskDef)
     {