Backoff on 503 errors for ask, find and search #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lferran
reviewed
Aug 13, 2024
| @@ -60,6 +62,13 @@ def _auth(self) -> NucliaAuth: | |||
|
|
|||
| @kb | |||
| @pretty | |||
| @backoff.on_exception( | |||
| backoff.expo, | |||
| exceptions.UnknownError, | |||
There was a problem hiding this comment.
This exception is raised for any 5xx error, so we'll be retrying all of them by default.
I'm not against it, but just to have it in mind. I think it would be better to retry specific status codes that we know will be resolved.
What intermittent error are you trying to fix?
ebrehault
force-pushed
the
ericbrehault/sc-10499/implement-back-off-on-search-in-the-python
branch
from
f29b407 to
993e30a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.