Merge pull request #6 from nuclia/test-connectors

test: Add tests for refresh_endpoint param in oauth connectors
nuclia · Jan 16, 2024 · a72620d · a72620d
2 parents 2d9380c + 91bc4ef
commit a72620d
Show file tree

Hide file tree

Showing 8 changed files with 105 additions and 0 deletions.
diff --git a/server/src/logic/connector/infrastructure/connectors/dropbox.connector.ts b/server/src/logic/connector/infrastructure/connectors/dropbox.connector.ts
@@ -32,6 +32,11 @@ export class DropboxImpl extends OAuthBaseConnector implements IConnector {
     if (!params?.refresh) {
       return false;
     }
+    try {
+      new URL(params.refresh_endpoint);
+    } catch (err) {
+      return false;
+    }
     return true;
   }
 

diff --git a/server/src/logic/connector/infrastructure/connectors/gdrive.connector.ts b/server/src/logic/connector/infrastructure/connectors/gdrive.connector.ts
@@ -32,6 +32,12 @@ export class GDriveImpl extends OAuthBaseConnector implements IConnector {
     if (!params?.refresh) {
       return false;
     }
+    try {
+      new URL(params.refresh_endpoint);
+    } catch (err) {
+      return false;
+    }
+
     return true;
   }
 

diff --git a/server/src/logic/connector/infrastructure/connectors/onedrive.connector.ts b/server/src/logic/connector/infrastructure/connectors/onedrive.connector.ts
@@ -32,6 +32,11 @@ export class OneDriveImpl extends OAuthBaseConnector implements IConnector {
     if (!params?.refresh) {
       return false;
     }
+    try {
+      new URL(params.refresh_endpoint);
+    } catch (err) {
+      return false;
+    }
     return true;
   }
 

diff --git a/server/src/logic/connector/infrastructure/connectors/sharepoint.connector.ts b/server/src/logic/connector/infrastructure/connectors/sharepoint.connector.ts
@@ -32,6 +32,11 @@ export class SharepointImpl extends OAuthBaseConnector implements IConnector {
     if (!params?.refresh) {
       return false;
     }
+    try {
+      new URL(params.refresh_endpoint);
+    } catch (err) {
+      return false;
+    }
     return true;
   }
 

diff --git a/server/src/logic/connector/infrastructure/connectors/tests/dropbox.connector.spec.js b/server/src/logic/connector/infrastructure/connectors/tests/dropbox.connector.spec.js
@@ -75,11 +75,31 @@ describe('Test validate dropbox params', () => {
     ).toBe(false);
   });
 
+  dropboxTest('Incorrect - With wrong params - two valid', ({ sourceConnector }) => {
+    expect(
+      sourceConnector.areParametersValid({
+        token: 'test',
+        refresh: 'test',
+      }),
+    ).toBe(false);
+  });
+
+  dropboxTest('Incorrect - With wrong params - invalid url', ({ sourceConnector }) => {
+    expect(
+      sourceConnector.areParametersValid({
+        token: 'test',
+        refresh: 'test',
+        refresh_endpoint: 'invalid_url',
+      }),
+    ).toBe(false);
+  });
+
   dropboxTest('Incorrect - With empty params', ({ sourceConnector }) => {
     expect(
       sourceConnector.areParametersValid({
         token: '',
         refresh: '',
+        refresh_endpoint: '',
       }),
     ).toBe(false);
   });
@@ -89,6 +109,7 @@ describe('Test validate dropbox params', () => {
       sourceConnector.areParametersValid({
         token: 'test',
         refresh: 'test',
+        refresh_endpoint: 'https://stashify.cloud/api/external_auth/gdrive/refresh',
       }),
     ).toBe(true);
   });

diff --git a/server/src/logic/connector/infrastructure/connectors/tests/gdrive.connector.spec.js b/server/src/logic/connector/infrastructure/connectors/tests/gdrive.connector.spec.js
@@ -84,11 +84,31 @@ describe('Test validate gdrive params', () => {
     ).toBe(false);
   });
 
+  gDriveTest('Incorrect - With wrong params - two valid', ({ sourceConnector }) => {
+    expect(
+      sourceConnector.areParametersValid({
+        token: 'test',
+        refresh: 'test',
+      }),
+    ).toBe(false);
+  });
+
+  gDriveTest('Incorrect - With wrong params - invalid url', ({ sourceConnector }) => {
+    expect(
+      sourceConnector.areParametersValid({
+        token: 'test',
+        refresh: 'test',
+        refresh_endpoint: 'invalid_url',
+      }),
+    ).toBe(false);
+  });
+
   gDriveTest('Incorrect - With empty params', ({ sourceConnector }) => {
     expect(
       sourceConnector.areParametersValid({
         token: '',
         refresh: '',
+        refresh_endpoint: '',
       }),
     ).toBe(false);
   });
@@ -98,6 +118,7 @@ describe('Test validate gdrive params', () => {
       sourceConnector.areParametersValid({
         token: 'test',
         refresh: 'test',
+        refresh_endpoint: 'https://stashify.cloud/api/external_auth/gdrive/refresh',
       }),
     ).toBe(true);
   });

diff --git a/server/src/logic/connector/infrastructure/connectors/tests/onedrive.connector.spec.js b/server/src/logic/connector/infrastructure/connectors/tests/onedrive.connector.spec.js
@@ -84,11 +84,31 @@ describe('Test validate gdrive params', () => {
     ).toBe(false);
   });
 
+  oneDriveTest('Incorrect - With wrong params - invalid url', ({ sourceConnector }) => {
+    expect(
+      sourceConnector.areParametersValid({
+        token: 'test',
+        refresh: 'test',
+        refresh_endpoint: 'invalid_url',
+      }),
+    ).toBe(false);
+  });
+
+  oneDriveTest('Incorrect - With wrong params - two valid', ({ sourceConnector }) => {
+    expect(
+      sourceConnector.areParametersValid({
+        token: 'test',
+        refresh: 'test',
+      }),
+    ).toBe(false);
+  });
+
   oneDriveTest('Incorrect - With empty params', ({ sourceConnector }) => {
     expect(
       sourceConnector.areParametersValid({
         token: '',
         refresh: '',
+        refresh_endpoint: '',
       }),
     ).toBe(false);
   });
@@ -98,6 +118,7 @@ describe('Test validate gdrive params', () => {
       sourceConnector.areParametersValid({
         token: 'test',
         refresh: 'test',
+        refresh_endpoint: 'https://stashify.cloud/api/external_auth/gdrive/refresh',
       }),
     ).toBe(true);
   });

diff --git a/server/src/logic/connector/infrastructure/connectors/tests/sharepoint.connector.spec.js b/server/src/logic/connector/infrastructure/connectors/tests/sharepoint.connector.spec.js
@@ -84,11 +84,31 @@ describe('Test validate sharepoint params', () => {
     ).toBe(false);
   });
 
+  sharepointTest('Incorrect - With wrong params - two valid', ({ sourceConnector }) => {
+    expect(
+      sourceConnector.areParametersValid({
+        token: 'test',
+        refresh: 'test',
+      }),
+    ).toBe(false);
+  });
+
+  sharepointTest('Incorrect - With wrong params - invalid url', ({ sourceConnector }) => {
+    expect(
+      sourceConnector.areParametersValid({
+        token: 'test',
+        refresh: 'test',
+        refresh_endpoint: 'invalid_url',
+      }),
+    ).toBe(false);
+  });
+
   sharepointTest('Incorrect - With empty params', ({ sourceConnector }) => {
     expect(
       sourceConnector.areParametersValid({
         token: '',
         refresh: '',
+        refresh_endpoint: '',
       }),
     ).toBe(false);
   });
@@ -98,6 +118,7 @@ describe('Test validate sharepoint params', () => {
       sourceConnector.areParametersValid({
         token: 'test',
         refresh: 'test',
+        refresh_endpoint: 'https://stashify.cloud/api/external_auth/gdrive/refresh',
       }),
     ).toBe(true);
   });