Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unconventional naming of V3IOStreamTrigger parameters by deprecating them #178

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

rokatyy
Copy link
Contributor

@rokatyy rokatyy commented Feb 5, 2024

@rokatyy rokatyy marked this pull request as ready for review February 5, 2024 14:55
nuclio/triggers.py Outdated Show resolved Hide resolved
nuclio/triggers.py Outdated Show resolved Hide resolved
nuclio/triggers.py Outdated Show resolved Hide resolved
nuclio/triggers.py Show resolved Hide resolved
tests/test_triggers.py Outdated Show resolved Hide resolved
Copy link

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@TomerShor TomerShor merged commit f800fe7 into nuclio:development Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants