[Build] Add a nuclio suffix to the module name if function is being deployed from the file
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
Jul 14, 2024
TomerShor
approved these changes
Jul 14, 2024
TomerShor
changed the title
nuclio suffix to the module name if function is being deployed from the filenuclio suffix to the module name if function is being deployed from the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where the name of a file in Nuclio conflicts with an existing Python library, causing the import to fail. To avoid such issues, we will add a
nucliosuffix to the filename when a function is being created from a file.Jira - https://iguazio.atlassian.net/browse/ML-6737