Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trigger] Add workerTerminationTimeout to KafkaTrigger #188

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[Trigger] Add workerTerminationTimeout to KafkaTrigger #188

merged 2 commits into from
Aug 6, 2024

Conversation

rokatyy
Copy link
Contributor

@rokatyy rokatyy commented Aug 6, 2024

@TomerShor TomerShor changed the title Add workerTerminationTimeout to KafkaTrigger [Trigger] Add workerTerminationTimeout to KafkaTrigger Aug 6, 2024
TomerShor
TomerShor requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@TomerShor TomerShor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to V3IOStreamTrigger too

@rokatyy rokatyy requested a review from TomerShor August 6, 2024 11:49
@TomerShor TomerShor merged commit ec901e4 into nuclio:development Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerShor TomerShor TomerShor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokatyy @TomerShor