Unifies some method names with other threshold projects #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzotova
force-pushed
the
unification-3
branch
from
72c0a9c
to
a2850ca
Compare
cygnusv
reviewed
Nov 16, 2023
| @@ -611,7 +618,7 @@ contract TACoApplication is IApplication, ITACoChildToRoot, OwnableUpgradeable { | |||
| /** | |||
| * @notice Returns staking provider for specified operator | |||
| */ | |||
| function stakingProviderFromOperator(address _operator) external view returns (address) { | |||
| function stakingProviderToOperator(address _operator) external view returns (address) { | |||
There was a problem hiding this comment.
This should be operatorToStakingProvider, isn't?
derekpierre
reviewed
Nov 21, 2023
theref
approved these changes
Nov 21, 2023
vzotova
force-pushed
the
unification-3
branch
from
3e91320
to
06ac3e5
Compare
cygnusv
approved these changes
Nov 21, 2023
| @@ -618,16 +625,14 @@ contract TACoApplication is IApplication, ITACoChildToRoot, OwnableUpgradeable { | |||
| /** | |||
| * @notice Returns staking provider for specified operator | |||
| */ | |||
| function stakingProviderFromOperator(address _operator) external view returns (address) { | |||
| function operatorToStakingProvider(address _operator) external view returns (address) { | |||
There was a problem hiding this comment.
This will require changes to nucypher. Opened nucypher/nucypher#3350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Unifies naming, see threshold-network/solidity-contracts#157
Breaks ABI