-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate support for python 3.12 #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need that? We should probably update ferveo
too
Same question as @piotr-roslaniec - is there a reason to support 3.12 before launch? Either way If intended for like a 7.1.0 - we can create a 7.1.0 branch in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nucypher-core
is already compatible with python 3.12 without additional changes so this is more of a maintenance formality. It will still be possible to use nucypher-core-python
with python 3.8 if this PR is merged.
That being said, there are noteworthy performance optimizations in python 3.12 that nodes can benefit from. The largest consumers and primary audience of the nucypher/nucypher repo will launch nodes with docker, which we can ship against python 3.12 instead of 3.8. By pre-building python wheels for 3.12 instead of 3.8 in this PR we optimize the newest version of python for the fastest install.
Additionally, python 3.8 is around 10 months away from EOL (in fact active support ceased two years ago).
Also see nucypher/nucypher#3327 |
Bumped Python version in |
We should probably do the same for |
Created nucypher/rust-umbral#130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
No description provided.