This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
New Worker Panel Styles #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KPrasch
commented
May 5, 2021
KPrasch
commented
- Based on Componentize Management Control Panels and Chart Elements #75
- Styles worker address collection closer to the spec
- Needs follow-up (see Handle invald or misconfigured worker address collection #79)
vepkenez
reviewed
May 5, 2021
|
|
||
| class StyledActiveDot extends React.Component { |
There was a problem hiding this comment.
why do this as a class based component?
vepkenez
reviewed
May 5, 2021
| @@ -23,60 +22,17 @@ function dateToUTCEpoch(d) { | |||
| return Number(Math.round(utcMilllisecondsSinceEpoch / 1000)) | |||
| } | |||
|
|
|||
| function oneYearAgo() { | |||
| function calculatePastEpoch(months_ago) { | |||
There was a problem hiding this comment.
maybe functions like this should go in here?
https://github.com/nucypher/nuit/blob/main/packages/react-app/src/services/nucypher.js
|
Something seems wrong with this PR. What are all these commits? Most of them seem to have nothing to do with styling this one little panel. |
This PR is based over #75, so with that merged it needs a rebase for GH to properly show the history (I'm hoping Microsoft will support automatically resolving it eventually). |
|
so safe to merge then... ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.