-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release [email protected]
#463
Release [email protected]
#463
Conversation
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
444159a
to
08184cb
Compare
08184cb
to
e72c07e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 23.97% 23.97%
=======================================
Files 62 62
Lines 9792 9792
Branches 260 260
=======================================
Hits 2348 2348
Misses 7385 7385
Partials 59 59 ☔ View full report in Codecov by Sentry. |
[email protected]
221a6f4
to
d8294f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -82,7 +82,7 @@ | |||
"node-forge@<1.3.0": ">=1.3.0", | |||
"glob-parent@<5.1.2": ">=5.1.2", | |||
"nth-check@<2.0.1": ">=2.0.1", | |||
"@nucypher/nucypher-core": "0.13.0-alpha.1" | |||
"@nucypher/nucypher-core": "^0.14.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging by nucypher/nucypher-core#89 there are no concerns about 0.14.1
not being compatible with nodes running 0.13.0
, correct? The breaking changes were limited to the wasm bindings, which the nodes don't care about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these changes are strictly for nucypher-core-wasm
and there is no impact on Python users.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@nucypher/taco", | |||
"version": "0.1.0", | |||
"version": "0.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 0.2.2 and not 0.2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I messed up and published a bad build. I yanked previous versions, but npmjs.com
doesn't allow republishing so I had to bump the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok 👍
Should the demos (taco-demo
, taco-nft-demo
) update their dependency to 0.2.2
?
Type of PR:
Required reviews:
Why it's needed:
@nucypher/nucypher-contracts
was updatedtaco-web
working fortapir
users