Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dotnet workload tools #1255

Merged
merged 6 commits into from
Nov 19, 2023
Merged

feat: add dotnet workload tools #1255

merged 6 commits into from
Nov 19, 2023

Conversation

ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Sep 11, 2023 •
edited
Loading

I have added the tools

  • DotNetWorkloadInstall
  • DotNetWorkloadRepair
  • DotNetWorkloadRestore
  • DotNetWorkloadUninstall
  • DotNetWorkloadUpdate

with the most sensible parameters (excluding -h|--help).

IMHO only the dotnet workload restore makes sense, because you cannot develop e.g. a maui app without having this workload installed. But I added it just in case.

Closes #1253

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@ITaluone ITaluone mentioned this pull request Sep 11, 2023
Closed
@ITaluone ITaluone force-pushed the feat/add-dotnet-workload-tools branch 4 times, most recently from 79c92a9 to 13d9d8a Compare September 11, 2023 13:40
@ITaluone ITaluone changed the title (feat): add dotnet workload tools feat: add dotnet workload tools Sep 11, 2023
@ITaluone ITaluone force-pushed the feat/add-dotnet-workload-tools branch from 13d9d8a to 19af9a8 Compare September 11, 2023 13:44
@matkoch matkoch force-pushed the feat/add-dotnet-workload-tools branch from 19af9a8 to 55f4c67 Compare November 19, 2023 21:30
@matkoch matkoch merged commit 1d86802 into nuke-build:develop Nov 19, 2023
3 of 4 checks passed
@matkoch
Copy link
Member

matkoch commented Nov 19, 2023

Thanks! I know these definitions are painful.

matkoch pushed a commit that referenced this pull request Nov 19, 2023
@ITaluone @matkoch
fix(tools): add missing DotNetTasks commands (#1255)
e3c3b05
@matkoch matkoch added this to the v7.1.0 milestone Nov 19, 2023
@ITaluone ITaluone deleted the feat/add-dotnet-workload-tools branch November 20, 2023 11:04
matkoch pushed a commit that referenced this pull request Dec 15, 2023
@ITaluone @matkoch
fix(tools): add missing DotNetTasks commands (#1255)
89a1a4a
matkoch pushed a commit that referenced this pull request Dec 15, 2023
@ITaluone @matkoch
fix(tools): add missing DotNetTasks commands (#1255)
c3c3100
@matkoch matkoch added the area:tools issues in this area can easily be fixed in user code label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:tools issues in this area can easily be fixed in user code
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

Add dotnet workload tools
2 participants
@ITaluone @matkoch