Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved local library scanner #1523

Merged
merged 27 commits into from
Mar 8, 2024
Merged

Improved local library scanner #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
18951cc
Merge previous scanner changes
nukeop Oct 27, 2023
4c88e09
Refactor visit_file function with dependency inversion to allow injec…
nukeop Oct 29, 2023
ccb7c5d
Cleanup code, fix warnings
nukeop Oct 30, 2023
2ac4191
Return thumbnails and disc number when scanning
nukeop Nov 1, 2023
db7f94f
Generate thumbnails in rust
nukeop Nov 3, 2023
00144d4
Implement FLAC scanning
nukeop Nov 9, 2023
d3dd1fb
Generate FLAC thumbnails
nukeop Nov 10, 2023
b48cc12
Refactor thumbnail generators
nukeop Nov 10, 2023
41c85db
Dependency inversion for visit_file
nukeop Nov 11, 2023
ababcea
Fix FLAC thumbnail generator
nukeop Nov 11, 2023
37d35f8
Refactor scanning code
nukeop Nov 12, 2023
468cb3f
Create a simple profiler for Rust code
nukeop Nov 13, 2023
0f725b2
Generate only one thumbnail per album
nukeop Nov 13, 2023
af45f27
Add support for MP4
nukeop Nov 13, 2023
27f37ab
Fix for FLAC duration
nukeop Nov 16, 2023
3a758fe
Fix measuring duration for MP3
nukeop Nov 16, 2023
607f5fe
Ogg metadata
nukeop Dec 1, 2023
d1feab6
Decode duration from ogg files
nukeop Mar 3, 2024
b0136a9
Disable unsupported m4a format
nukeop Mar 4, 2024
ae45d93
Return any image data when generating mp3 covers
nukeop Mar 4, 2024
c61a4cc
Deprecate no longer supported formats
nukeop Mar 6, 2024
a26a382
Add UUID to queue items and fix sorting criteria
nukeop Mar 8, 2024
b88a852
Update local library tests to use a uuid regex
nukeop Mar 8, 2024
89bcade
Disable local library scanner test
nukeop Mar 8, 2024
789c02b
Commented out local library scanner test code
nukeop Mar 8, 2024
319e19c
Add setup tools installation for macOS
nukeop Mar 8, 2024
9e8a22c
Add setup tools installation for macOS
nukeop Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ jobs:
run: |
echo "C:\Program Files\Git\usr\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
echo "C:\Program Files\Git\mingw64\libexec\git-core" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
- name: install setup tools
if: runner.os == 'macOS'
run: |
sudo -H pip install setuptools
- run: npm ci
- run: npm run lint
- run: npm test
Expand Down Expand Up @@ -92,6 +96,10 @@ jobs:
run: |
echo "C:\Program Files\Git\usr\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
echo "C:\Program Files\Git\mingw64\libexec\git-core" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
- name: install setup tools
if: runner.os == 'macOS'
run: |
sudo -H pip install setuptools
- run: npm ci
- run: npm run ${{ matrix.platform.cmd }}
shell: bash
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,4 @@ build-dir
#Travis/IDE stuff
.travis.yml
.vs/
target/*
Loading
Loading