Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly map date_created_edtf as keyword type #4125

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Aug 28, 2024

Summary

Explicitly map date_created_edtf as keyword type so that it won't infer as date type

Specific Changes in this PR

  • Update dc-v2-work mappings to explicitly map date_created_edtf as keyword type

Version bump required by the PR

See Semantic Versioning 2.0.0 for help discerning which is required.

  • Patch
  • Minor
  • Major

Steps to Test

  • After reindex, from Kibana get work mappings and verify date_created_edtf field type is keyword.

🚀 Deployment Notes

Note - if you check any of these boxes go to the (always open) main <- staging PR and add detailed notes and instructions to help out others who may end up deploying your changes to production

  • Backward compatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Backwards-incompatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Requires data migration
  • Requires database triggers disabled during deployment/migration
  • Requires reindex
  • Terraform changes
    • Adds/requires new or changed Terraform variables
  • Pipeline configuration changes (requires mix meadow.pipeline.setup run)
  • Requires new variable added to miscellany
  • Specific deployment synchronization instructions with other apps/API's
  • Other specific instructions/tasks

Tested/Verified

  • End users/stakeholders

@kdid kdid self-assigned this Aug 28, 2024
@kdid kdid requested a review from mbklein August 28, 2024 17:33
@kdid kdid merged commit ce402db into deploy/staging Aug 28, 2024
4 checks passed
@kdid kdid deleted the 5146-edtf-date-keyword branch August 28, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants