-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Popper Timeout Tracking (#1417)
We noticed that Popper was sometimes closing the dropdown inaccurately. This was pinned down to timeouts being incorrectly cleared, and therefore sometimes running when they ought not to. Careful examination of the code revealed that they weren't being tracked very well, and thus stomped on or lost. This approach leverages a ref to track the value to avoid loss during re-renders, and to also avoid unnecessary re-renders. * chore: Initial tidying pass on Popper * Add a few missing types * Let the code breathe a bit * fix: Better Popper Timeout Tracking --------- Co-authored-by: Haider Alshamma <[email protected]>
- Loading branch information
1 parent
a1d511b
commit e026714
Showing
2 changed files
with
54 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"formatter": { | ||
"enabled": true, | ||
"indentStyle": "space", | ||
"lineWidth": 120 | ||
}, | ||
"linter": { | ||
"enabled": false | ||
}, | ||
"javascript": { | ||
"formatter": { | ||
"trailingComma": "es5" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters