Skip to content

Commit

Permalink
Update outdated content in README.md (#24)
Browse files Browse the repository at this point in the history
Signed-off-by: chandankumar4 <[email protected]>
  • Loading branch information
chandankumar4 authored Nov 27, 2024
1 parent 58a68e2 commit 087167f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: CI

on:
pull_request:
paths-ignore:
- '**/README.md'
push:
branches:
- main
paths-ignore:
- '**/README.md'

jobs:
lint-test:
Expand Down
8 changes: 3 additions & 5 deletions charts/numaflow/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,15 @@ Output:
```bash
NAME: numaflow
LAST DEPLOYED: Thu Jan 18 19:51:50 2024
LAST DEPLOYED: Wed Nov 27 10:20:41 2024
NAMESPACE: numaflow-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
export POD_NAME=$(kubectl get pods --namespace numaflow-system -l "app.kubernetes.io/name=numaflow-server" -o jsonpath="{.items[0].metadata.name}")
export CONTAINER_PORT=$(kubectl get pod --namespace numaflow-system $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
kubectl --namespace numaflow-system port-forward $POD_NAME $CONTAINER_PORT
echo "Visit http://127.0.0.1:$CONTAINER_PORT to use your application"
kubectl --namespace numaflow-system port-forward svc/numaflow-server 8443
echo "Visit https://127.0.0.1:8443 to use your application"
```
you have successfully installed Numaflow!!!
Expand Down
6 changes: 2 additions & 4 deletions charts/numaflow/templates/NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
export SERVICE_IP=$(kubectl get svc --namespace {{ .Release.Namespace }} numaflow-server --template "{{"{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}"}}")
echo http://$SERVICE_IP:{{ include "server.configs.port" . }}
{{- else if contains "ClusterIP" .Values.server.service.type }}
export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name=numaflow-ux" -o jsonpath="{.items[0].metadata.name}")
export CONTAINER_PORT=$(kubectl get pod --namespace {{ .Release.Namespace }} $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME $CONTAINER_PORT
echo "Visit http://127.0.0.1:$CONTAINER_PORT to use your application"
kubectl --namespace {{ .Release.Namespace }} port-forward svc/numaflow-server 8443
echo "Visit https://127.0.0.1:8443 to use your application"
{{- end }}

0 comments on commit 087167f

Please sign in to comment.