Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix example paths for async_log and async_source #183

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

ayildirim21
Copy link
Member

Kindly explain what this PR does.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (61195e5) to head (73af5c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   94.65%   94.70%   +0.04%     
==========================================
  Files          52       52              
  Lines        2003     2003              
  Branches      119      119              
==========================================
+ Hits         1896     1897       +1     
+ Misses         78       77       -1     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
@kohlisid
Copy link
Contributor

@ayildirim21 Please attach the screenshot from the build and CI test for reference

@ayildirim21
Copy link
Member Author

Builds for async_source and async_log:

Screenshot 2024-07-12 at 12 39 09 PM

Screenshot 2024-07-12 at 12 39 09 PM

Healthy async_log pipeline:

Screenshot 2024-07-12 at 12 48 02 PM

Healthy async_source pipeline:

Screenshot 2024-07-12 at 12 51 06 PM

@kohlisid kohlisid merged commit bf2b55a into numaproj:main Jul 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants