feat: bi-directional streaming map #197
Conversation
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
kohlisid
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 94.24% 94.20% -0.04%
==========================================
Files 56 55 -1
Lines 2259 2314 +55
Branches 145 154 +9
==========================================
+ Hits 2129 2180 +51
- Misses 96 98 +2
- Partials 34 36 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sidhant Kohli <[email protected]>
kohlisid
changed the title
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
| # If the message is an exception, we raise the exception | ||
| if isinstance(msg, BaseException): | ||
| await handle_async_error(context, msg) | ||
| return |
There was a problem hiding this comment.
We are not really returning anything right? But it should ideally be AsyncIterable[map_pb2.MapResponse] correct?
There was a problem hiding this comment.
Correct, but the error handler would have sent a context error back, hence empty return for exit here.
| d = Datum( | ||
| keys=list(request.request.keys), | ||
| value=request.request.value, | ||
| event_time=request.request.event_time.ToDatetime(), | ||
| watermark=request.request.watermark.ToDatetime(), | ||
| headers=dict(request.request.headers), | ||
| ) |
There was a problem hiding this comment.
Do we need to have this part inside the try except?
There was a problem hiding this comment.
If there is a type issue, good to catch that mostly
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
|
E2E test |
Kindly explain what this PR does.