Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adaptive lookback seconds for monovertex #2299

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

kohlisid
Copy link
Contributor

No description provided.

kohlisid and others added 14 commits December 19, 2024 12:59
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 46.65179% with 239 lines in your changes missing coverage. Please review.

Project coverage is 66.81%. Comparing base (bb4a0de) to head (f6a8e18).

Files with missing lines Patch % Lines
...aemon/server/service/rater/rater_lookback_utils.go 17.11% 88 Missing and 4 partials ⚠️
rust/numaflow-core/src/shared/insecure_tls.rs 0.00% 67 Missing ⚠️
rust/numaflow-core/src/metrics.rs 30.15% 44 Missing ⚠️
pkg/mvtxdaemon/server/service/rater/helper.go 37.50% 20 Missing ⚠️
pkg/mvtxdaemon/server/service/rater/rater.go 76.66% 7 Missing ⚠️
pkg/mvtxdaemon/server/service/mvtx_service.go 0.00% 4 Missing ⚠️
rust/numaflow-core/src/lib.rs 0.00% 4 Missing ⚠️
rust/numaflow-core/src/monovertex.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
- Coverage   67.17%   66.81%   -0.36%     
==========================================
  Files         349      352       +3     
  Lines       44992    45432     +440     
==========================================
+ Hits        30222    30357     +135     
- Misses      13699    13999     +300     
- Partials     1071     1076       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants