Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cascade deletion on isbsvc pvc #2305

Merged
merged 1 commit into from
Dec 25, 2024
Merged

chore: cascade deletion on isbsvc pvc #2305

merged 1 commit into from
Dec 25, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Dec 25, 2024

Starting from k8s v1.27, PVC auto deletion was introduced, became stable in v1.32. Hence we don't need to handle it any more.

Backward compatible with k8s < v1.27, verified in v1.26.

@whynowy whynowy requested a review from vigith as a code owner December 25, 2024 09:26
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (677cc59) to head (02ae274).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/apis/numaflow/v1alpha1/deprecated.go 0.00% 7 Missing ⚠️
pkg/reconciler/isbsvc/installer/jetstream.go 40.00% 2 Missing and 1 partial ⚠️
pkg/reconciler/isbsvc/installer/native_redis.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2305      +/-   ##
==========================================
- Coverage   67.07%   67.06%   -0.01%     
==========================================
  Files         349      349              
  Lines       44969    44992      +23     
==========================================
+ Hits        30162    30176      +14     
- Misses      13735    13750      +15     
+ Partials     1072     1066       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whynowy whynowy merged commit bb4a0de into numaproj:main Dec 25, 2024
25 checks passed
@whynowy whynowy deleted the vl branch December 25, 2024 19:44
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants