Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logs enhancements #2320

Merged
merged 6 commits into from
Jan 15, 2025
Merged

feat: logs enhancements #2320

merged 6 commits into from
Jan 15, 2025

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Jan 9, 2025

enhanced numaflow logs to:

  • added monospacing

  • updated logs font, removed colours for log level

  • allow wrapping lines (preventing horizontal scroll)

image
  • ability to download logs (format - "{pod_name}-{container_name}.txt")
image
  • ability to add / remove timestamps from the beginning of logs
image image
  • add filters for log levels (info, error, warn, debug)
image

Signed-off-by: veds-g <[email protected]>
@veds-g veds-g requested review from whynowy and vigith as code owners January 9, 2025 23:02
@veds-g veds-g requested review from adarsh0728 and mshakira January 9, 2025 23:03
@vigith
Copy link
Member

vigith commented Jan 9, 2025

awesome.. please make sure default is "single line" log (not wrap)

Signed-off-by: veds-g <[email protected]>
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.26%. Comparing base (2922173) to head (993c08c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2320      +/-   ##
==========================================
- Coverage   67.29%   67.26%   -0.03%     
==========================================
  Files         351      351              
  Lines       45272    45272              
==========================================
- Hits        30465    30453      -12     
- Misses      13738    13749      +11     
- Partials     1069     1070       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veds-g veds-g marked this pull request as draft January 11, 2025 12:23
@veds-g veds-g marked this pull request as ready for review January 14, 2025 16:27
Signed-off-by: veds-g <[email protected]>
Copy link
Contributor

@yhl25 yhl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vigith vigith merged commit 376a602 into numaproj:main Jan 15, 2025
25 checks passed
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants