fix: units and tooltip content for metric charts #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adarsh0728 <[email protected]>
|
2 decimal precision and unit("ms") in tooltip value: |
Signed-off-by: adarsh0728 <[email protected]>
|
Metric Description info icon: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2333 +/- ##
==========================================
- Coverage 67.94% 67.81% -0.13%
==========================================
Files 352 352
Lines 46527 46529 +2
==========================================
- Hits 31613 31555 -58
- Misses 13833 13896 +63
+ Partials 1081 1078 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: adarsh0728 <[email protected]>
veds-g
reviewed
Jan 21, 2025
...als/NodeInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/LineChart/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
jacque1ine
pushed a commit
to jacque1ine/numaflow
that referenced
this pull request
Jan 23, 2025
Signed-off-by: adarsh0728 <[email protected]> Signed-off-by: jacque1ine <[email protected]>
jacque1ine
pushed a commit
to jacque1ine/numaflow
that referenced
this pull request
Jan 23, 2025
Signed-off-by: adarsh0728 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metric_descriptionin the config for each metric so that it can be displayed in the info icon next to metric's display name.