feat: rows/page dropbox. Fixes #1764 #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaniyaKalamkar
force-pushed
the
new-navpages
branch
2 times, most recently
from
7cf6782 to
4750e3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2337 +/- ##
==========================================
- Coverage 58.21% 57.85% -0.37%
==========================================
Files 402 469 +67
Lines 28061 55296 +27235
==========================================
+ Hits 16337 31991 +15654
- Misses 10790 22227 +11437
- Partials 934 1078 +144 ☔ View full report in Codecov by Sentry. |
adarsh0728
reviewed
Jan 21, 2025
ui/src/components/common/SlidingSidebar/partials/K8sEvents/index.tsx
Outdated
Show resolved
Hide resolved
mshakira
reviewed
Jan 21, 2025
veds-g
reviewed
Jan 21, 2025
ui/src/components/common/SlidingSidebar/partials/K8sEvents/index.tsx
Outdated
Show resolved
Hide resolved
mshakira
reviewed
Jan 21, 2025
veds-g
reviewed
Jan 21, 2025
ui/src/components/common/SlidingSidebar/partials/K8sEvents/index.tsx
Outdated
Show resolved
Hide resolved
veds-g
reviewed
Jan 21, 2025
ui/src/components/common/SlidingSidebar/partials/K8sEvents/index.tsx
Outdated
Show resolved
Hide resolved
veds-g
reviewed
Jan 21, 2025
ui/src/components/common/SlidingSidebar/partials/K8sEvents/index.tsx
Outdated
Show resolved
Hide resolved
veds-g
reviewed
Jan 21, 2025
ui/src/components/common/SlidingSidebar/partials/K8sEvents/index.tsx
Outdated
Show resolved
Hide resolved
SaniyaKalamkar
force-pushed
the
new-navpages
branch
2 times, most recently
from
0680aa3 to
2c7c527
Compare
|
for the |
Signed-off-by: Saniya Kalamkar <[email protected]>
…f-by: Saniya Kalamkar <[email protected]> Signed-off-by: Saniya Kalamkar <[email protected]>
…alamkar <[email protected]> Signed-off-by: Saniya Kalamkar <[email protected]>
SaniyaKalamkar
force-pushed
the
new-navpages
branch
from
15b475f to
eac9e63
Compare
|
Thank you for the contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1764. Created rows per page option so events being displayed is not fixed at 6.
Edit: Changed style of dropbox: