docs: add kafka-java to Kafka source/sink docs #2347
Conversation
Signed-off-by: Keran Yang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2347 +/- ##
==========================================
+ Coverage 68.11% 68.22% +0.10%
==========================================
Files 352 352
Lines 46500 46500
==========================================
+ Hits 31673 31724 +51
+ Misses 13743 13701 -42
+ Partials 1084 1075 -9 ☔ View full report in Codecov by Sentry. |
|
|
||
| More details on how to use the Kafka Sink can be found [here](https://github.com/numaproj-contrib/kafka-java?tab=readme-ov-file#write-data-to-kafka). | ||
|
|
||
| ## Option 2: Built-in Kafka Sink |
There was a problem hiding this comment.
Reverse the order of the 2 options?
There was a problem hiding this comment.
we are eventually deprecating builtin, right?
There was a problem hiding this comment.
I put kafka-java first because I want it to get some attentions and feedbacks so that we can further improve it towards fully feature-complete.
There was a problem hiding this comment.
@whynowy mind if I keep kafka-java as first?
There was a problem hiding this comment.
Go ahead. I assume we will use this one as the builtin soon.
Signed-off-by: Keran Yang <[email protected]> Signed-off-by: jacque1ine <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Explain what this PR does.