Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) test: add fallback sink to mvtx e2e test #2348

Closed
wants to merge 1 commit into from

Conversation

jacque1ine
Copy link
Contributor

Explain what this PR does.

@jacque1ine jacque1ine changed the title remove double space fix: remove double space Jan 21, 2025
@KeranYang KeranYang changed the title fix: remove double space test: add fallback sink to mvtx e2e test Jan 21, 2025
@KeranYang KeranYang changed the title test: add fallback sink to mvtx e2e test (WIP) test: add fallback sink to mvtx e2e test Jan 21, 2025
@KeranYang
Copy link
Member

We will use the PR to add fallback sink to the mvtx e2e test case.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.93%. Comparing base (c492520) to head (87bb486).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
- Coverage   67.94%   67.93%   -0.02%     
==========================================
  Files         352      352              
  Lines       46527    46527              
==========================================
- Hits        31613    31608       -5     
- Misses      13833    13850      +17     
+ Partials     1081     1069      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacque1ine jacque1ine closed this Jan 22, 2025
@jacque1ine jacque1ine deleted the fix/remove-double-space branch January 22, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants