Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jitter #305

Merged
merged 11 commits into from
Oct 2, 2023
Merged

feat: add jitter #305

merged 11 commits into from
Oct 2, 2023

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Sep 30, 2023

  1. Add jitter
    • for caches
    • for model saving
  2. Support RegistryConf and JitterConf

Signed-off-by: s0nicboOm <[email protected]>
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #305 (4f5fce3) into main (2f6d965) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   93.89%   93.99%   +0.09%     
==========================================
  Files          77       77              
  Lines        3459     3483      +24     
  Branches      277      279       +2     
==========================================
+ Hits         3248     3274      +26     
+ Misses        159      158       -1     
+ Partials       52       51       -1     
Files Coverage Δ
numalogic/config/_config.py 100.00% <100.00%> (ø)
numalogic/registry/artifact.py 93.33% <100.00%> (+1.33%) ⬆️
numalogic/registry/localcache.py 96.77% <100.00%> (ø)
numalogic/registry/redis_registry.py 96.91% <100.00%> (+1.20%) ⬆️
numalogic/tools/exceptions.py 100.00% <100.00%> (ø)
numalogic/udfs/_config.py 100.00% <100.00%> (ø)
numalogic/udfs/inference.py 94.52% <100.00%> (+0.07%) ⬆️
numalogic/udfs/postprocess.py 86.66% <100.00%> (+0.18%) ⬆️
numalogic/udfs/preprocess.py 87.95% <100.00%> (+0.14%) ⬆️
numalogic/udfs/trainer.py 91.79% <100.00%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: s0nicboOm <[email protected]>
@s0nicboOm s0nicboOm marked this pull request as ready for review September 30, 2023 06:56
Signed-off-by: s0nicboOm <[email protected]>
numalogic/registry/artifact.py Outdated Show resolved Hide resolved
numalogic/registry/redis_registry.py Outdated Show resolved Hide resolved
numalogic/registry/redis_registry.py Outdated Show resolved Hide resolved
Copy link

@qhuai qhuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple of minor comments. Overall it looks good to me.

numalogic/config/_config.py Show resolved Hide resolved
numalogic/registry/artifact.py Outdated Show resolved Hide resolved
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

numalogic/config/_config.py Outdated Show resolved Hide resolved
numalogic/registry/redis_registry.py Outdated Show resolved Hide resolved
@ab93 ab93 added the area/registry Persistence/Storage changes label Oct 2, 2023
s0nicboOm and others added 3 commits October 2, 2023 09:39
@s0nicboOm s0nicboOm merged commit f25f49a into numaproj:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Persistence/Storage changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants