Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fix examples ipynb files #318

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

haripriyajk
Copy link
Contributor

This PR updates outdated modules being used n the python notebooks in the examples folder.

Fixes #316

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #318 (150acd7) into main (61f4575) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files          76       76           
  Lines        3464     3464           
  Branches      278      278           
=======================================
  Hits         3246     3246           
  Misses        170      170           
  Partials       48       48           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haripriyajk
Copy link
Contributor Author

@s0nicboOm @ab93 @nkoppisetty @qhuai please review this PR

Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I Know why did we remove %load_ext autotime ?

Also, can you rebase your PR?

Otherwise looks good to me.

@haripriyajk haripriyajk force-pushed the update-examples-ipynb branch from df7c50e to 2837617 Compare October 31, 2023 15:56
@haripriyajk
Copy link
Contributor Author

May I Know why did we remove %load_ext autotime ?
I have removed it as its not present in quick_start.ipynb and I was not able to import it or install it without issues.I forgot to add it back before merging.Let me know if I should add it back.
Also, can you rebase your PR?

Otherwise looks good to me.

@haripriyajk haripriyajk requested a review from s0nicboOm November 2, 2023 06:28
Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haripriyajk
Copy link
Contributor Author

I see that the PR is has passed all the checks,can we merge this?

@vigith vigith merged commit 0bbb53d into numaproj:main Nov 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The example ipynb files have outdated modules
3 participants