Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified close method according to recommendation in asyncio docs #112

Merged
merged 1 commit into from
Mar 30, 2024
Merged

modified close method according to recommendation in asyncio docs #112

merged 1 commit into from
Mar 30, 2024

Conversation

treychaffin
Copy link
Contributor

I was getting a TypeError (NoneType) when closing a TCP connection.

By modifying the close method according to the asyncio StreamWriter close method docs, the issue was resolved.

@alexrudd2
Copy link
Member

Thanks; good catch!

@alexrudd2 alexrudd2 merged commit e0a5160 into numat:master Mar 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treychaffin @alexrudd2