secure codegen by not returning a default value

As title
numba · May 31, 2024 · 57ca469 · 57ca469
1 parent ab0b337
commit 57ca469
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/numba_rvsdg/core/datastructures/ast_transforms.py b/numba_rvsdg/core/datastructures/ast_transforms.py
@@ -787,7 +787,7 @@ def codegen_view() -> list[Any]:
             ]
         elif type(block) is SyntheticTail:
             # Synthetic tails do nothing.
-            pass
+            return []
         elif type(block) is SyntheticFill:
             # Synthetic fills must have a pass statement to main syntactical
             # correctness of the final program.
@@ -861,7 +861,8 @@ def if_cascade(jump_targets: list[str]) -> list[ast.AST]:
             return if_cascade(list(block.jump_targets[::-1]))
         else:
             raise NotImplementedError
-        return []
+
+        raise NotImplementedError("unreachable")
 
 
 def AST2SCFG(code: str | list[ast.FunctionDef] | Callable[..., Any]) -> SCFG: