CI Updates #115
Merged
CI Updates #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This updates the makefile such that the targets can be used on the command line when developing and during the GHA when doing continuous integration (CI). Also, we fold the pre-commit GHA into the main testing, rather than having this a seprarate task. |
makefile
Outdated
| conda create -n numba-rvsdg | ||
| conda-install: | ||
| conda install python=3.12 python-graphviz pyyaml pytest sphinx sphinx_rtd_theme coverage pre-commit | ||
| pip install -U virtualenv |
There was a problem hiding this comment.
@esc I wonder if conda install virtualenv will work too...
There was a problem hiding this comment.
I tried that, but when I use pip I get virtualenv-20.26.1 anaconda.org only has 20.17.1 which seems to old.
As title
As title
Thank you for the review, I added two more snippets to update some dependencies and also making a note about the need for |
skupr-anaconda
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title