Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup ast_transform docs #128

Merged
merged 2 commits into from
May 31, 2024
Merged

Fixup ast_transform docs #128

merged 2 commits into from
May 31, 2024

Conversation

esc
Copy link
Member

@esc esc commented May 29, 2024

So that they render and read well as HTML.

So that they render and read well as HTML.
@esc esc requested a review from kc611 May 29, 2024 10:17
* i = next(__iterator_1__, '__sentinel__') # get next i
* if i != '__sentinel__': # regular iteration
* ``__iter_last_1__ = i ## backup value of i``
* ``i = next(__iterator_1__, '__sentinel__') # * get next i``
Copy link
Contributor

@kc611 kc611 May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick but the rendering of this particular line makes the RHS comment shift right quite a bit. Which overall makes it look very haphazard. Could all the RHS comments in this sections be shifted right by the same amount so as to match the indentation of this particular line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is such that it is easier to keep the lines in sync with the above as the indentation level is matched. For the output, they render without all the leading whitespace anyway as shown here. I would prefer thus to keep them as is.

Screenshot 2024-05-29 at 14 02 46

As title
@esc esc requested a review from kc611 May 30, 2024 06:04
Copy link
Contributor

@kc611 kc611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is such that it is easier to keep the lines in sync with the above as the indentation level is matched. For the output, they render without all the leading whitespace anyway as shown here. I would prefer thus to keep them as is.

Yeah that sounds fine.

@esc esc merged commit 7dc58d1 into numba:main May 31, 2024
2 checks passed
@esc
Copy link
Member Author

esc commented May 31, 2024

@kc611 thank you for the review.

@esc esc deleted the docs/ast_transforms branch June 1, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants