-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup ast_transform docs #128
Conversation
So that they render and read well as HTML.
* i = next(__iterator_1__, '__sentinel__') # get next i | ||
* if i != '__sentinel__': # regular iteration | ||
* ``__iter_last_1__ = i ## backup value of i`` | ||
* ``i = next(__iterator_1__, '__sentinel__') # * get next i`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick but the rendering of this particular line makes the RHS comment shift right quite a bit. Which overall makes it look very haphazard. Could all the RHS comments in this sections be shifted right by the same amount so as to match the indentation of this particular line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is such that it is easier to keep the lines in sync with the above as the indentation level is matched. For the output, they render without all the leading whitespace anyway as shown here. I would prefer thus to keep them as is.
Yeah that sounds fine.
@kc611 thank you for the review. |
So that they render and read well as HTML.