Use hypothesis for tests #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think this is an interesting idea, but feel it's perhaps best placed on hold until there are some actual use cases/implementations about which the merits of such an approach can be discussed? |
|
Sure! I sent it even though there was only one simple test to serve as an idea and a reference, instead of coming back to the repository when there are a thousand tests and having to migrate them all :) |
|
@stuartarchibald do you think it might be time to pick this up again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A humble proposal to use Hypothesis for the tests. It will likely make them more robust, and going forward help the developers catch corner cases (like
np.nan,np.inf, etc).