Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all embedded DSO handling to use mkstemp. #37

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

stuartarchibald
Copy link
Contributor

This switches all internal use of shm based embedded DSO handling to mkstemp based embedded DSO handling. An issue was identified in testing where a /dev/shm mount could have the noexec flag set (seemingly quite common in docker containers) and as a result of this embedded DSOs extracted to this location could not be executed. Resolving this will take some time and so as a temporary measure the aforementioned switch is being made.

This switches all internal use of shm based embedded DSO handling
to mkstemp based embedded DSO handling. An issue was identified in
testing where a /dev/shm mount could have the `noexec` flag set
(seemingly quite common in docker containers) and as a result of
this embedded DSOs extracted to this location could not be
executed. Resolving this will take some time and so as a temporary
measure the aforementioned switch is being made.
@stuartarchibald stuartarchibald marked this pull request as ready for review July 4, 2024 17:37
@esc
Copy link
Member

esc commented Jul 4, 2024

I can confirm that this works fine within a linux-64 docker container on a linux-64 host that has /dev/shm set to noexec.

Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esc esc merged commit 3e386b9 into numba:main Jul 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants