This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Fix build error on arm64 Linux #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a condition to CMakeLists.txt to avoid having to undefine NTA_ASM when building on arm64 |
|
Ok, will do. Off to set up a Windows build environment :) |
|
@rhyolight I assume this is 64 bit Windows 10 (and not arm either), correct? |
|
@paulscode sorry see my comment on #1438 |
|
@paulscode can you merge in master as soon as #1442 is merged? Then CI will run again with his changes. |
|
Sorry this took so long. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1439