💄(frontend) updating the header and leftpanel for responsive #421
+245
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanchoutNathan
force-pushed
the
new-ui/layout-header
branch
from
5bfd34f
to
8b460a9
Compare
PanchoutNathan
changed the title
PanchoutNathan
force-pushed
the
new-ui/layout-header
branch
2 times, most recently
from
069b7b8
to
8268b26
Compare
PanchoutNathan
force-pushed
the
main-new-ui
branch
from
9b33a1f
to
01ef324
Compare
PanchoutNathan
force-pushed
the
new-ui/layout-header
branch
4 times, most recently
from
1457933
to
d75d175
Compare
PanchoutNathan
changed the title
PanchoutNathan
force-pushed
the
new-ui/layout-header
branch
from
d75d175
to
4126d55
Compare
AntoLC
reviewed
Nov 18, 2024
src/frontend/apps/impress/src/features/header/components/Header.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/header/components/Header.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/header/components/Header.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/components/separators/HorizontalSeparator.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx
Outdated
Show resolved
Hide resolved
PanchoutNathan
force-pushed
the
new-ui/layout-header
branch
2 times, most recently
from
0abeaf4
to
12906e6
Compare
PanchoutNathan
force-pushed
the
new-ui/layout-header
branch
2 times, most recently
from
5522232
to
4ddcbd7
Compare
Previously we added a left panel. We now need to adapt the layout so that it becomesresponsive. We therefore add a burger menu on the left on mobile which, when clicked, deploys the left-panel over all the content.
Deleted two components that were no longer needed following the implementation of the new interface. This cleanup helps streamline he codebase and avoid unnecessary maintenance.
PanchoutNathan
force-pushed
the
new-ui/layout-header
branch
from
4ddcbd7
to
9779b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously we added a left panel. We now need to adapt the layout so that it becomes responsive.
We therefore add a burger menu on the left on mobile which, when clicked, deploys the left-panel over all the content.
Enregistrement.de.l.ecran.2024-11-18.a.09.56.02.mov