refactor: removed dedicated clients as they are now configurable

.github/workflows/end-to-end.yml

@@ -45,10 +45,10 @@ jobs:
           - redirect_after_session_expiration
           - reset_password
           - set_info_after_account_provisioning
-          - signin_from_legacy_client
           - signin_from_proconnect_federation_client
           - signin_from_standard_client
           - signin_with_email_verification_renewal
+          - signin_with_legacy_scope
           - signin_with_magic_link
           - signin_with_right_acr
           - signin_with_totp
@@ -86,18 +86,6 @@ jobs:
           STYLESHEET_URL: ""
           LOGIN_HINT: [email protected]
           ACR_VALUES: eidas1
-      moncomptepro-legacy-client:
-        image: ghcr.io/numerique-gouv/moncomptepro-test-client
-        ports:
-          - 4002:3000
-        env:
-          SITE_TITLE: moncomptepro-legacy-client
-          HOST: http://localhost:4002
-          MCP_CLIENT_ID: legacy_client_id
-          MCP_CLIENT_SECRET: legacy_client_secret
-          MCP_PROVIDER: ${{ env.MONCOMPTEPRO_HOST }}
-          MCP_SCOPES: openid email profile phone organizations
-          STYLESHEET_URL: ""
       redis:
         image: redis:7.2
         ports:

cypress/e2e/signin_from_legacy_client/fixtures.sql → cypress/e2e/signin_with_legacy_scope/fixtures.sql

@@ -23,25 +23,14 @@ INSERT INTO oidc_clients
    userinfo_signed_response_alg, id_token_signed_response_alg,
    authorization_signed_response_alg, introspection_signed_response_alg)
 VALUES
-  ('Oidc Test Client',
-   'legacy_client_id',
-   'legacy_client_secret',
-   ARRAY [
-     'http://localhost:4002/login-callback'
-     ],
-   ARRAY []::varchar[],
-   'openid email profile phone organizations',
-   'http://localhost:4002/',
-   'MonComptePro test client. More info: https://github.com/numerique-gouv/moncomptepro-test-client.',
-   null, null, null, null),
   ('Oidc Test Client',
    'standard_client_id',
    'standard_client_secret',
    ARRAY [
      'http://localhost:4000/login-callback'
      ],
    ARRAY []::varchar[],
-   'openid email profile organization',
+   'openid email profile phone organization organizations',
    'http://localhost:4000/',
    'MonComptePro test client. More info: https://github.com/numerique-gouv/moncomptepro-test-client.',
    null, null, null, null);

cypress/e2e/signin_from_legacy_client/index.cy.ts → cypress/e2e/signin_with_legacy_scope/index.cy.ts

@@ -1,13 +1,16 @@
 //
 
-describe("sign-in from legacy client", () => {
+describe("sign-in with legacy scope", () => {
   it("should sign-in", function () {
-    cy.visit("http://localhost:4002");
-    cy.get("button.proconnect-button").click();
+    cy.visit("http://localhost:4000");
+    cy.setCustomParams({
+      scope: "openid email profile phone organizations",
+    });
+    cy.get("button#custom-connection").click({ force: true });
 
     cy.login("[email protected]");
 
-    cy.contains("moncomptepro-legacy-client");
+    cy.contains("moncomptepro-standard-client");
     cy.contains("[email protected]");
     cy.contains("Commune de lamalou-les-bains");
 

docker-compose.yml

@@ -56,19 +56,6 @@ services:
       ACR_VALUES: eidas1
     network_mode: "host"
 
-  moncomptepro-legacy-client:
-    image: ghcr.io/numerique-gouv/moncomptepro-test-client
-    environment:
-      PORT: 4002
-      SITE_TITLE: moncomptepro-legacy-client
-      HOST: http://localhost:4002
-      MCP_CLIENT_ID: legacy_client_id
-      MCP_CLIENT_SECRET: legacy_client_secret
-      MCP_PROVIDER: http://localhost:3000
-      MCP_SCOPES: openid email profile phone organizations
-      STYLESHEET_URL:
-    network_mode: "host"
-
   maildev:
     image: soulteary/maildev
     network_mode: "host"