feat: more resilient email comparison

numerique-gouv · Oct 9, 2023 · 8a8870e · 8a8870e
1 parent 52e81e1
commit 8a8870e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/connectors/api-annuaire-education-nationale.ts b/src/connectors/api-annuaire-education-nationale.ts
@@ -226,16 +226,18 @@ export const getAnnuaireEducationNationaleContactEmail = async (
     },
   ] = records;
 
-  if (!isEmailValid(mail)) {
+  const formattedEmail = mail.toLowerCase().trim();
+
+  if (!isEmailValid(formattedEmail)) {
     throw new ApiAnnuaireInvalidEmailError();
   }
 
   if (DO_NOT_USE_ANNUAIRE_EMAILS) {
     console.log(
-      `Test email address ${TEST_CONTACT_EMAIL} was used instead of the real one ${mail}.`
+      `Test email address ${TEST_CONTACT_EMAIL} was used instead of the real one ${formattedEmail}.`
     );
     return TEST_CONTACT_EMAIL;
   }
 
-  return mail;
+  return formattedEmail;
 };
diff --git a/src/connectors/api-annuaire-service-public.ts b/src/connectors/api-annuaire-service-public.ts
@@ -100,16 +100,18 @@ export const getAnnuaireServicePublicContactEmail = async (
     },
   ] = features;
 
-  if (!isEmailValid(email)) {
+  const formattedEmail = email.toLowerCase().trim();
+
+  if (!isEmailValid(formattedEmail)) {
     throw new ApiAnnuaireInvalidEmailError();
   }
 
   if (DO_NOT_USE_ANNUAIRE_EMAILS) {
     console.log(
-      `Test email address ${TEST_CONTACT_EMAIL} was used instead of the real one ${email}.`
+      `Test email address ${TEST_CONTACT_EMAIL} was used instead of the real one ${formattedEmail}.`
     );
     return TEST_CONTACT_EMAIL;
   }
 
-  return email;
+  return formattedEmail;
 };