Installation improvements #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit nitpicky here but I feel like having a "Testing the Application" heading to talk about the local app url and login info is a bit misleading. As I was just quickly scanning the docs via headings I actually skipped this part at first thinking "I don't need to worry about tests right now".
when installing the project by just reading the docs, there was no step where assets were installed. I guess the best would be to include this as a postinstall script but the safest thing to quickly merge is to just add doc for now.
manuhabitela
force-pushed
the
improve-install
branch
from
02546e8
to
850b917
Compare
|
@rdubigny updated my commit to remove the postinstall stuff, only added a script to easily build all assets and mentioned it in the docs |
|
Obsolete now that the assets handling is changing with #489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are two ideas, explained in details in the commit descriptions, to improve a bit the installation process.
Let me know what you think 👌