Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide keypass button if not configured #703

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: hide keypass button if not configured #703

merged 1 commit into from
Sep 23, 2024

Conversation

rdubigny
Copy link
Contributor

@rdubigny rdubigny commented Sep 23, 2024 •
edited
Loading

This PR hide the option to login with passkey if the user has not configured it.

Without Passkey configured:

image

With Passkey configured:

image

renardpal
renardpal reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@renardpal renardpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

très bien de supprimer si y'a pas de config.
S'il y en a une : ce serait encore mieux que le btn passkey s'affiche avant celui du magic link

@rdubigny rdubigny merged commit 6a9da94 into master Sep 23, 2024
28 checks passed
@rdubigny rdubigny deleted the do-not-shows-webauthn-button branch September 23, 2024 16:01
@rdubigny
Copy link
Contributor Author

ETQU, si je n'ai pas configuré de clé webauthn pour mon compte, je ne vois pas l'option webauthn pour me connecter sur la page de login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renardpal renardpal renardpal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdubigny @renardpal