Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(www): redirect to square start if the user is not found #875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(www): redirect to square start if the user is not found #875

wants to merge 1 commit into from

Conversation

douglasduteil
Copy link
Member

image

\following #779

@douglasduteil douglasduteil added the bug Something isn't working label Dec 5, 2024
@douglasduteil douglasduteil self-assigned this Dec 5, 2024
@douglasduteil
Copy link
Member Author

❎ Faux négatif sur Sentry : Retour à la case départ si l'utilisateur qui souhaite se connecter est introuvable (NotFoundError)

@rdubigny
Copy link
Contributor

rdubigny commented Jan 8, 2025 •
edited
Loading

Vu ensemble : on préférera tester dans getSignInController que l’user existe bien en base (et qu'il ait un password) avant de rendre la page. Si ce n'est pas le cas on peut au choix :

  • rendre une page d'erreur explicite
  • rediriger vers /users/sign-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdubigny rdubigny Awaiting requested review from rdubigny

Assignees

@douglasduteil douglasduteil

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglasduteil @rdubigny