🐛(dimail) fix unexpected status_code for proper debug

Remove duplicate and catch errors more gracefully. Fixes tests accordingly.

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to
 
 ### Fixed
 
+- 🐛(dimail) fix unexpected status_code for proper debug #454
 - ✏️(mail) fix typo into mailbox creation email
 - 🐛(sentry) fix duplicated sentry errors #479
 - 🐛(script) improve and fix release script

src/backend/mailbox_manager/tests/api/mailboxes/test_api_mailboxes_create.py

@@ -12,6 +12,7 @@
 
 import pytest
 import responses
+from requests.exceptions import HTTPError
 from rest_framework import status
 from rest_framework.test import APIClient
 
@@ -500,8 +501,7 @@ def test_api_mailboxes__user_unrelated_to_domain():
         assert not models.Mailbox.objects.exists()
 
 
-@mock.patch.object(Logger, "error")
-def test_api_mailboxes__handling_dimail_unexpected_error(mock_error):
+def test_api_mailboxes__handling_dimail_unexpected_error(caplog):
     """
     API should raise a clear error when dimail returns an unexpected response.
     """
@@ -526,12 +526,12 @@ def test_api_mailboxes__handling_dimail_unexpected_error(mock_error):
         rsps.add(
             rsps.POST,
             re.compile(rf".*/domains/{access.domain.name}/mailboxes/"),
-            body='{"details": "Internal server error"}',
+            body='{"detail": "Internal server error"}',
             status=status.HTTP_500_INTERNAL_SERVER_ERROR,
             content_type="application/json",
         )
 
-        with pytest.raises(SystemError):
+        with pytest.raises(HTTPError):
             response = client.post(
                 f"/api/v1.0/mail-domains/{access.domain.slug}/mailboxes/",
                 mailbox_data,
@@ -544,10 +544,9 @@ def test_api_mailboxes__handling_dimail_unexpected_error(mock_error):
         assert not models.Mailbox.objects.exists()
 
         # Check error logger was called
-        assert mock_error.called
-        assert mock_error.call_args_list[1][0] == (
-            'Unexpected response from dimail: 500 {"details": "Internal server error"}',
-        )
+        assert len(caplog.records) == 2  # 1 + new empty info. To be investigated
+        assert caplog.records[0].levelname == "ERROR"
+        assert caplog.records[0].message == "[DIMAIL] 500: Internal server error"
 
 
 @mock.patch.object(Logger, "error")

src/backend/mailbox_manager/utils/dimail.py

@@ -1,5 +1,6 @@
 """A minimalist client to synchronize with mailbox provisioning API."""
 
+import json
 import smtplib
 from logging import getLogger
 
@@ -10,6 +11,7 @@
 from django.utils.translation import gettext_lazy as _
 
 import requests
+from requests.exceptions import HTTPError
 from rest_framework import status
 from urllib3.util import Retry
 
@@ -152,14 +154,15 @@ def send_mailbox_request(self, mailbox, user_sub=None):
 
     def pass_dimail_unexpected_response(self, response):
         """Raise error when encountering an unexpected error in dimail."""
-        error_content = response.content.decode("utf-8")
+        error_content = json.loads(response.content.decode("utf-8").replace("'", '"'))
 
-        logger.error(
-            "[DIMAIL] unexpected error : %s %s", response.status_code, error_content
-        )
-        raise SystemError(
-            f"Unexpected response from dimail: {response.status_code} {error_content}"
-        )
+        # catch error just to add failing interop name
+        try:
+            response.raise_for_status()
+        except HTTPError as error:
+            raise HTTPError(
+                f"[DIMAIL] {response.status_code}: {error_content['detail']}"
+            ) from error
 
     def send_new_mailbox_notification(self, recipient, mailbox_data):
         """