Skip to content

Commit

Permalink
🐛(i18n) dot in key was not added
Browse files Browse the repository at this point in the history
The parser was not adding the dot in the key to the
json file sent to crowdin. Some translations were
not being translated correctly.
  • Loading branch information
AntoLC committed Feb 19, 2024
1 parent 1909e55 commit ddcdfef
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
8 changes: 3 additions & 5 deletions src/frontend/apps/desk/src/i18n/translations.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"fr": {
"translation": {
"Create a team": "Créer un groupe",
"Create a team.": "Créer un groupe",
"Marianne Logo": "Logo Marianne",
"Freedom Equality Fraternity Logo": "Logo Liberté Égalité Fraternité",
"Desk Logo": "Logo Desk",
Expand Down Expand Up @@ -29,15 +29,13 @@
"Teams icon": "Icône de groupe",
"Empty teams icon": "Icône de groupe vide",
"Something bad happens, please refresh the page": "Une erreur inattendue s'est produite, rechargez la page.",
"0 group to display": "0 groupe à afficher.",
"Create your first team by clicking on the \"Create a new team\" button": "Créez votre premier groupe en cliquant sur le bouton \"Créer un nouveau groupe\".",
"0 group to display.": "0 groupe à afficher.",
"Create new team card": "Carte créer une nouvelle équipe",
"Something bad happens, please retry.": "Une erreur inattendue s'est produite, rechargez la page.",
"0 group to display.": "0 groupe à afficher.",
"Create your first team by clicking on the \"Create a new team\" button.": "Créez votre premier groupe en cliquant sur le bouton \"Créer un nouveau groupe\".",
"Something bad happens, please refresh the page.": "Une erreur inattendue s'est produite, rechargez la page.",
"Members of “{{teamName}}“": "Membres de “{{teamName}}“",
"Add people to the “{{teamName}}“ group": "Ajouter des personnes au groupe «{{teamName}}».",
"Add people to the “{{teamName}}“ group.": "Ajouter des personnes au groupe {{teamName}}.",
"{{count}} member_one": "{{count}} membre",
"{{count}} member_many": "{{count}} membres",
"{{count}} member_other": "{{count}} membres",
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/packages/i18n/__tests__/translations.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('checks all the frontend translation are made', () => {

if (missingKeys.length > 0) {
console.log(
`Missing keys in Desk translations that should be translated in Crowdin, got to https://crowdin.com/:`,
`Missing keys in Desk translations that should be translated in Crowdin, got to https://crowdin.com/ :`,
missingKeys,
);
}
Expand Down
1 change: 1 addition & 0 deletions src/frontend/packages/i18n/i18next-parser.config.jest.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const config = {
description: '${description}',
},
keepRemoved: false,
keySeparator: false,
};

export default config;
1 change: 1 addition & 0 deletions src/frontend/packages/i18n/i18next-parser.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const config = {
description: '${description}',
},
keepRemoved: true,
keySeparator: false,
};

export default config;

0 comments on commit ddcdfef

Please sign in to comment.