💬(app-desk) translate en plurals keys correctly #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebaudantoine
approved these changes
Mar 26, 2024
Comment on lines
53
to
56
| "Open the team options": "Ouvrir les options de groupe dans la fenêtre modale", | ||
| "Open the team options": "Ouvre les options de groupe", |
There was a problem hiding this comment.
let's keep ouvrir no ?
AntoLC
force-pushed
the
fix/i18n/english-plural
branch
from
3b34158
to
2f24840
Compare
We stopped the use Crowdin for every PR, so we need to synch the translations here and there to be sure all the translations are up to date.
The potential unused keys was the ones from other PR, but we don't use crowdin with every PR, so we don't need to keep the unused keys in the translation files.
We added the english language in Crowdin. We can now translate the plural keys in the english language.
AntoLC
force-pushed
the
fix/i18n/english-plural
branch
from
2f24840
to
c9a8149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We added the english language in Crowdin.
We can now translate the plural keys in the english language.
Proposal
Demo