Update CI to publish docker image #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebaudantoine
force-pushed
the
al-ci-docker
branch
3 times, most recently
from
3872c2c
to
fbe1fc6
Compare
lebaudantoine
force-pushed
the
al-ci-docker
branch
from
fbe1fc6
to
daf052c
Compare
lebaudantoine
changed the title
sampaccoud
reviewed
Feb 6, 2024
AntoLC
reviewed
Feb 6, 2024
rouja
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM,
Do not forget to cleanup this image if you do not use it : https://hub.docker.com/layers/lasuite/people/pr-40/images/sha256-cd1a93e3a04a9122bab215afbc6bbc4d2eebeffde38419dc793d2a471a5b7ec1?context=explore
lebaudantoine
force-pushed
the
al-ci-docker
branch
from
daf052c
to
872b694
Compare
Added Docker Hub username and password, to shared secrets.
Refactored 'Hub' CI job for clarity, using 'docker/build-push-action.' This dedicated workflow efficiently manages image releases on push tag and main branch merges events. 'Hub' job was broken by Chat GPT translation from Circle CI. Images are pushed to a temporary Docker Hub repository, lasuite/people. Duplicated 'build-docker' job was removed from people workflow.
lebaudantoine
force-pushed
the
al-ci-docker
branch
from
872b694
to
ae92de7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Publish production Docker images for staging deployment.
Proposal
I have followed the basic usage of these configurations.
Images are pushed to this public Docker Hub repository.
It closes, #39 .